Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Fix shader cache with transform feedback on some Android devices #88549

Closed
wants to merge 1 commit into from

Conversation

Arthas92t
Copy link
Contributor

Fix issue #82419 tested on vivo 1907, vsmart active 3, samsung a12

@Arthas92t Arthas92t requested a review from a team as a code owner February 19, 2024 13:15
@akien-mga akien-mga changed the title Fix shader cache with transform feedback on some android devices Fix shader cache with transform feedback on some Android devices Feb 19, 2024
@akien-mga
Copy link
Member

Thanks for contributing and welcome!

The rendering team will have to address the code change specifically, but there's a few form issues with this PR that also needs to be addressed:

  • PRs should be made against the master branch. The production team will then cherry-pick relevant fixes to actively maintained stable branches once they are fixed in master. If we only merged this in 4.2, it means the bug would still exist when 4.3 is released.
    • The simplest way to fix this would be for you to make a new PR from another branch based off master. It's recommended to make commits from a dedicated branch for each PR, instead of making it from your fork's master branch (which would make it tricky for you to make other PRs until the first one has been merged).
  • Your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

@akien-mga akien-mga added this to the 4.2 milestone Feb 19, 2024
@akien-mga akien-mga changed the title Fix shader cache with transform feedback on some Android devices [4.2Fix shader cache with transform feedback on some Android devices Feb 19, 2024
@akien-mga akien-mga changed the title [4.2Fix shader cache with transform feedback on some Android devices [4.2] Fix shader cache with transform feedback on some Android devices Feb 19, 2024
@Arthas92t
Copy link
Contributor Author

Sorry, it's the first time i contribute something to github. Most time i work with local and private git. I will change this in the next PR

@Arthas92t Arthas92t changed the base branch from 4.2 to master February 19, 2024 14:47
@Arthas92t Arthas92t requested review from a team as code owners February 19, 2024 14:47
@AThousandShips AThousandShips removed this from the 4.2 milestone Feb 20, 2024
@AThousandShips AThousandShips removed request for a team February 20, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants