Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide separators in ItemList in editor theme #88575

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Hide separators in ItemList in editor theme #88575

merged 1 commit into from
Feb 27, 2024

Conversation

davthedev
Copy link
Contributor

@davthedev davthedev requested review from a team as code owners February 20, 2024 01:10
@KoBeWi KoBeWi added this to the 4.x milestone Feb 20, 2024
@KoBeWi
Copy link
Member

KoBeWi commented Feb 25, 2024

ItemList is also used in About Godot dialog:
image

And with this PR it looks like this:
image

Calinou
Calinou approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. In the future, we should consider adding an option to use alternating row colors in ItemList and Tree to make odd lines easier to distinguish from even lines, without relying on borders.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 26, 2024
@akien-mga akien-mga merged commit e8b94e6 into godotengine:master Feb 27, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@davthedev @KoBeWi @akien-mga @Calinou