Change glow calculation back to max(r,g,b)
#88612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
Feb 21, 2024
akien-mga
changed the title
max(r,g,b)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #87360 based on a remark by @clayjohn :
In this PR I change the calculation back to max(r, g, b) which gives a more pronounced glow on all colors. I've also renamed the variable because it isn't really a luminance calculation, it's really the max strength that is important here for the glow, as we end up using the color as is. I think with the normal luminance calculation we're actually doubling up and making the glow fairly unusable..