Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenGL on Android after adding optional depth fog #88633

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Feb 21, 2024

After PR #84792 was merged, I'm getting this error on Android (I'm testing on the Meta Quest 3) with the OpenGL renderer:

02-21 09:51:43.351 24292 24339 E godot   : USER ERROR: SceneShaderGLES3: Fragment shader compilation failed:
02-21 09:51:43.351 24292 24339 E godot   : ERROR: 0:989: '-' :  wrong operand types  no operation '-' exists that takes a left-hand operand of type 'const int' and a right operand of type 'float' (or there is no acceptable conversion)
02-21 09:51:43.351 24292 24339 E godot   : ERROR: 0:989: 'assign' :  cannot convert from 'const int' to 'float'
02-21 09:51:43.351 24292 24339 E godot   : ERROR: 2 compilation errors.  No code generated.

This PR fixes that!

@akien-mga akien-mga merged commit 16d6142 into godotengine:master Feb 21, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@dsnopek dsnopek deleted the opengl-android-fog-fix branch July 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants