Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3D editor project settings update #88645

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fix 3D editor project settings update #88645

merged 1 commit into from
Feb 22, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Feb 21, 2024

Fixes #88642

@KoBeWi KoBeWi added this to the 4.3 milestone Feb 21, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner February 21, 2024 19:21
@akien-mga
Copy link
Member

Why did this break the logic? Intuitively, it seems to make sense, all settings retrieved in this method are under rendering.

@KoBeWi
Copy link
Member Author

KoBeWi commented Feb 22, 2024 •
edited
Loading

Because it's project settings :P

check_changed_settings_in_group() is EditorSettings method.

@akien-mga akien-mga merged commit 2f58db9 into godotengine:master Feb 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the 🤦‍♂️🤦‍♂️🤦‍♂️ branch February 22, 2024 13:45
@matheusmdx matheusmdx mentioned this pull request Jun 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Viewport related settings are not updated realtime
2 participants
@KoBeWi @akien-mga