Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spammy dev-mode message about load deadlock prevention #88706

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Feb 23, 2024

This message has turned out not to be very useful, given how frequent is the deadlock prevention being triggered. Well, that make it sound as if removing the message was kind of hiding an issue, but that's not the case. It's only natural that resource loading has to take that path on some thread-dependency combinations. Therefore, the message is not really telling anything very special and, on the contrary, it's polluting the log.

@RandomShaper RandomShaper added this to the 4.3 milestone Feb 23, 2024
@RandomShaper RandomShaper requested a review from a team as a code owner February 23, 2024 13:57
@akien-mga akien-mga merged commit 491cd40 into godotengine:master Feb 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the no_spammy_wtp branch February 26, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants