Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak of scene used for customization during export #88726

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

RandomShaper
Copy link
Member

It's not only a waste of memory, but scripts hooking to certain callbacks can start running without a way to stop them but restarting the editor.

@RandomShaper RandomShaper added bug topic:editor cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 23, 2024
@RandomShaper RandomShaper added this to the 4.3 milestone Feb 23, 2024
@akien-mga akien-mga merged commit 4ec8976 into godotengine:master Feb 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the node_cust_leak branch February 26, 2024 12:30
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants