Add new scene import option to import as Skeleton #88819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuma
force-pushed
the
import_nodes_as_skeleton_bones
branch
2 times, most recently
from
0a26b5a
to
97cfdf1
Compare
Mickeon
approved these changes
Feb 25, 2024
| @@ -667,6 +678,10 @@ void SceneImportSettingsDialog::open_settings(const String &p_path, bool p_for_a | |||
| first_aabb = false; | |||
| } | |||
|
|
|||
| const HashMap<StringName, Variant> &main_settings = scene_import_settings_data->current; | |||
| if (main_settings.find("nodes/import_as_skeleton_bones")) { | |||
There was a problem hiding this comment.
Suggested change
| if (main_settings.find("nodes/import_as_skeleton_bones")) { | |
| if (main_settings.has("nodes/import_as_skeleton_bones")) { |
|
I love this so much! At some point I've spent countless hours trying to import an "empty nodes" animation from an FBX. Blender wasn't much help either, even with a "Better FBX" plugin. I think having this in core will save many users from a lot of headache. |
Adds a bool import option `nodes/import_as_skeleton_bones`. This is supported in all FBX or GLTF document based formats. It is especially useful for retargeting and importing animations.
lyuma
force-pushed
the
import_nodes_as_skeleton_bones
branch
from
97cfdf1
to
652ef96
Compare
TokageItLab
approved these changes
Feb 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bool import option
nodes/import_as_skeleton_bones.This is supported in all FBX or GLTF document based formats. It is especially useful for retargeting and importing animations.
Examples:
Before:
After:
Fixes #81935
Fixes #62275 (if not already fixed by ufbx)
May mitigate problems such as #78028, though this is really an export bug
I suspect there are more issues