Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking scene multiplayer: Fix removing connected peer during disconnection #88826

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

mhilbrunner
Copy link
Member

@mhilbrunner mhilbrunner commented Feb 25, 2024

Obvious typo. Spent a few minutes investigating all uses of .has() in the codebase and found no other similar mistakes. Still, I wonder if automated detection of code without any effect is possible for us.

Spotted by user danielsnd on RC.

@mhilbrunner mhilbrunner added bug topic:network cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 25, 2024
@mhilbrunner mhilbrunner requested a review from Faless February 25, 2024 17:47
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 25, 2024
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obvious typo indeed.

@akien-mga akien-mga merged commit 924e579 into godotengine:master Feb 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@mhilbrunner mhilbrunner deleted the net-fix-has-erase branch February 26, 2024 14:42
@akien-mga
Copy link
Member

akien-mga commented Mar 11, 2024

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants