Don't attempt shutting down adb on exit if not started #88865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Feb 26, 2024
KoBeWi
reviewed
Feb 26, 2024
| @@ -416,7 +416,7 @@ void EditorExportPlatformAndroid::_check_for_changes_poll_thread(void *ud) { | |||
| } | |||
| } | |||
|
|
|||
| if (EDITOR_GET("export/android/shutdown_adb_on_exit")) { | |||
| if (ea->has_runnable_preset.is_set() && EDITOR_GET("export/android/shutdown_adb_on_exit")) { | |||
| String adb = get_adb_path(); | |||
| if (!FileAccess::exists(adb)) { | |||
There was a problem hiding this comment.
You could add the preset check here, it would be more consistent with the check for device updates above.
EDIT:
I mean this
Suggested change
| if (!FileAccess::exists(adb)) { | |
| if (!ea->has_runnable_preset.is_set() || !FileAccess::exists(adb)) { |
There was a problem hiding this comment.
True, but there's no point querying the editor setting or getting the adb path if we'll skip using it.
KoBeWi
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88864.