Fix BoneAttachment3D responding to only local transform changes
#88884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TokageItLab This is something in your area, may you take a look? |
TokageItLab
approved these changes
Mar 2, 2024
|
Thanks! |
|
This is important for moving games using bone, will version 4.2 be released in merger?thanks for reply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoneAttachment3Dwas only listening to local transform changes. That means ifoverride_posewas turned on, and theBoneAttachment3Dwas moved as part of a parent object (no local transform changes), it does nothing, in editor and at runtime. See broken behaviour below:This PR corrects this by listening to global transform changes. See fixed behaviour:
