C#: Only check for empty deprecation message if deprecated #88921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Nice catch! Thank you so much.
- Follow-up to C#: Add deprecated message to generated bindings #88730.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent bug caused glue compilation time to increase drastically, and it came down to a new warning being printed everytime a deprecated message was empty. Meant to be placeholder, but it erroneously did this check at all times, even on non-deprecated systems which very obviously wouldn't have deprecation messages. This fixes that by implementing an extra check to see if something is actually deprecated before making the check & spouting a warning.