Core: Add Callable.create static method for Variant callables
#88948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Feb 28, 2024
dalexeev
force-pushed
the
core-add-callable-create
branch
from
ec5527f to
0cb7de0
Compare
adamscott
approved these changes
Feb 28, 2024
Mickeon
reviewed
Feb 28, 2024
| @@ -160,7 +188,11 @@ | |||
| <method name="is_custom" qualifiers="const"> | |||
| <return type="bool" /> | |||
| <description> | |||
| Returns [code]true[/code] if this [Callable] is a custom callable. Custom callables are created from [method bind] or [method unbind]. In GDScript, lambda functions are also custom callables. | |||
| Returns [code]true[/code] if this [Callable] is a custom callable. Custom callables are used: | |||
There was a problem hiding this comment.
I may be better to reword the list to describe how custom Callables are created, how to create and obtain them, rather than list what they're used for.
I have no suggestions at the moment.
nlupugla
reviewed
Feb 28, 2024
nlupugla
reviewed
Feb 28, 2024
nlupugla
reviewed
Feb 28, 2024
nlupugla
reviewed
Feb 28, 2024
nlupugla
reviewed
Feb 28, 2024
dalexeev
force-pushed
the
core-add-callable-create
branch
from
0cb7de0 to
d90c9db
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Varianttypes to be used as Callables #82264.Callable(Variant, StringName)constructor is quite difficult to implement due to binding limitations.