Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rendering/2d/snap/snap_2d_vertices_to_pixel setting to advanced view #88963

Merged

Conversation

adamscott
Copy link
Member

Follow-up to #88456. (I wanted to comment on that PR but I completely forgot about this.)

This PR hides rendering/2d/snap/snap_2d_vertices_to_pixel from the basic settings view. rendering/2d/snap/snap_2d_transforms_to_pixel was overhauled with #87297, and that makes rendering/2d/snap/snap_2d_vertices_to_pixel somewhat unneeded.

So, by hiding the latter setting, we make sure that people would only activate the relevant one.

Also edited the documentation in order to reflect on that.

cc. the original author of #88456, @sabslikesobs

@adamscott adamscott requested review from a team as code owners February 28, 2024 15:38
@AThousandShips AThousandShips changed the title Hide rendering/2d/snap/snap_2d_vertices_to_pixel setting to advanced view Move rendering/2d/snap/snap_2d_vertices_to_pixel setting to advanced view Feb 28, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 28, 2024
doc/classes/ProjectSettings.xml Outdated Show resolved Hide resolved
doc/classes/ProjectSettings.xml Outdated Show resolved Hide resolved
@adamscott adamscott force-pushed the hide-to-advanced-snap-2d-vertices branch from 507621e to dcf4cf7 Compare February 28, 2024 15:59
@akien-mga akien-mga merged commit 9cf48f5 into godotengine:master Feb 29, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Proggle
Copy link
Contributor

Proggle commented Mar 7, 2024

This PR hides rendering/2d/snap/snap_2d_vertices_to_pixel from the basic settings view. rendering/2d/snap/snap_2d_transforms_to_pixel was overhauled with #87297, and that makes rendering/2d/snap/snap_2d_vertices_to_pixel somewhat unneeded.

I tried this PR, and I'm still getting considerable sprite bleed with snap transforms to pixel enabled ( #67164 ), while snap vertices to pixel is almost entirely bleed free. So there's definitely a current use case where vertex snapping works a lot better - I don't think hiding the old setting in 'advanced' is really justified when the replacement doesn't fix the same problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants