Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix early activation of particle trail sections #89042

Merged

Conversation

permelin
Copy link
Contributor

@permelin permelin commented Mar 1, 2024

Fixes #88712

All particle trail sections were activated at once on the first cycle, instead of being spread out over the trail's lifetime.

@permelin permelin requested a review from a team as a code owner March 1, 2024 13:54
@AThousandShips AThousandShips added this to the 4.3 milestone Mar 1, 2024
Fixes godotengine#88712

All particle trail sections were activated at once on the first cycle, instead
of being spread out over the trail's lifetime.
@permelin permelin force-pushed the fix-particle-trail-activation branch from 3bf81bb to 9b2d77a Compare March 1, 2024 18:33
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested locally and it works

@clayjohn clayjohn added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 7, 2024
@akien-mga akien-mga merged commit cebaf9d into godotengine:master Mar 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
@permelin permelin deleted the fix-particle-trail-activation branch March 19, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trail particles activated before fully initialized
4 participants