Do not attempt to set cursor shape in headless mode. #89099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riteo
requested changes
Mar 2, 2024
|
Looks good! Could you squash the commits? See PR workflow for instructions. |
chrisl8
force-pushed
the
no_custom_cursor_error_in_headless
branch
from
f5d5255 to
20e6321
Compare
Co-authored-by: Riteo <riteo@posteo.net>
chrisl8
force-pushed
the
no_custom_cursor_error_in_headless
branch
from
20e6321 to
e6d0bf3
Compare
Riteo
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
Looks fine and dandy! :D
You started something really nice BTW, I think we should do this to other "special" calls, one of which comes to mind: the pesky icon setting code that prints a warning on startup on Wayland, as there's no support for "runtime" icons in the first place.
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time I run anything in
--headlessmode I receive this warning:WARNING: Custom cursor shape not supported by this display server.
This does not seem helpful or useful to me. Instead it distracts from the process and encourages us to get used to ignoring errors and warnings without reading them each time.
My, possibly naive, interpretation of the code is that it can skip this step always when running
--headlesswith no negative effect, but if I'm wrong, feel free to reject.It seems to work for me.