-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for JSONRPC #89124
Merged
Merged
Add unit tests for JSONRPC #89124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Calinou
reviewed
Apr 9, 2024
wheatear-dev
force-pushed
the
test-json-rpc
branch
from
April 10, 2024 15:44
d0cd33a
to
b15912e
Compare
Calinou
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wheatear-dev
force-pushed
the
test-json-rpc
branch
from
April 10, 2024 17:27
b15912e
to
6b4a759
Compare
99 tasks
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to #43440, this PR contains several unit tests for the
JSONRPC
module.Dictionary
orArray
) derived classes ofVariant
produce a well-formatted error when given toJSONRPC::process_action
JSONRPC::process_string
TestClassJSONRPC
class, and its public methodsomething
(that appends", please"
to the inputString
):Dictionary
works correctlyArray
has each of its innerDictionary
elements iterated overSimilarly to #89021,
DOCTEST_CONFIG_NO_EXCEPTIONS_BUT_WITH_ALL_ASSERTS
was added to theCPPDEFINES
of theJSONRPC
module, if both tests are enabled and exceptions are disabled, so that theREQUIRE
assert could be used.