Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class reference: Improve TileMap get_cell_atlas_coords documentation #89146

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

BlueberryGecko
Copy link
Contributor

Improve documentation for the get_cell_atlas_coords in TileMaps to include the returned value if cell is empty (does not exist).

References:

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these descriptions do annoy me but this is an nice improvement.

One nitpick being that the commit's name could have been more specific, but that's okay.

@akien-mga akien-mga changed the title Class reference: Improve TileMap get_cell_atlas_coords documentation Class reference: Improve TileMap get_cell_atlas_coords documentation Mar 4, 2024
@akien-mga akien-mga merged commit 4ac4132 into godotengine:master Mar 4, 2024
16 checks passed
@akien-mga
Copy link
Member

akien-mga commented Mar 4, 2024

Thanks! And congrats for your first merged Godot contribution 🎉

@BlueberryGecko
Copy link
Contributor Author

BlueberryGecko commented Mar 4, 2024

Thank you all, and thanks for merging!

@Mickeon do you have a concrete suggestion on how to formulate it better? Maybe something like

Class reference: Describe return value of TileMap::get_cell_atlas_coords for empty cells

? I was originally afraid my commit message would get too long, but that's about the same length, haha.

Mainly asking because I'm now starting to seriously use Godot and will likely contribute more in the future.

@Mickeon
Copy link
Contributor

Mickeon commented Mar 4, 2024

Hey, it's all good, No worries. Yeah, that would've been a better title. Thank you for your contribution nonetheless, they're the small things that count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants