Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GDScript] Fix some test file paths #89151

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[GDScript] Fix some test file paths #89151

merged 1 commit into from
Mar 4, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Mar 4, 2024 •
edited
Loading

Fixed spaces or - instead of _

@AThousandShips AThousandShips added this to the 4.3 milestone Mar 4, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner March 4, 2024 18:00
dalexeev
dalexeev approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my typo. 😱 Thank you for the fix!

@AThousandShips
Copy link
Member Author

Should I go ahead and normalize the names completely? With - -> _ or should I leave it?

@dalexeev
Copy link
Member

dalexeev commented Mar 4, 2024

Should I go ahead and normalize the names completely? With - -> _ or should I leave it?

That would be great!

@AThousandShips
Copy link
Member Author

TIL that Windows file explorer has a batch rename feature, helped a lot for this

@akien-mga akien-mga merged commit 5802bd9 into godotengine:master Mar 4, 2024
16 checks passed
@AThousandShips AThousandShips deleted the path_fix branch March 4, 2024 19:47
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @dalexeev @akien-mga