Expose profile_changed signal to XRController3D
#89219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Mar 6, 2024
akien-mga
changed the title
profile_changed signal to XRController3D
akien-mga
reviewed
Mar 6, 2024
devloglogan
force-pushed
the
xr-profile-changed
branch
from
2f4fba7 to
c51f8e9
Compare
devloglogan
force-pushed
the
xr-profile-changed
branch
from
c51f8e9 to
1383401
Compare
akien-mga
approved these changes
Mar 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the
XRPositionalTrackerprofile_changedsignal to users throughXRController3D, just like otherXRPositionalTrackersignals likebutton_pressed,input_float_changed, etc.Because the interaction profile changes as users swap between using controllers and hand tracking, making this signal available to users provides an easy way for them to detect that change. This was discussed a bit in GodotVR/godot_openxr_vendors#98