Fix region section not ignoring #region and #endregion when in a string #89242
Conversation
|
Wouldn't it make more sense to add |
|
@Kiisu-Master Yeah, for some reason when I changed it before, it was still giving me the wrong results, so I thought there was something else that I wasn't seeing and I didn't want to break anything else, so I did it this way. But now when I tried it again it now works perfectly. |
There was a problem hiding this comment.
Thanks for the contribution!
Code and tests looks good to me.
Any chance you could rebase and squash your commits, we have some documentation here that should help: https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#updating-your-branch
When using the script editor, if the keywords #region and #endregion where in a string and ate the start of the line, the editor would not ignore them and count them as the actual keywords, which when folded, would only fold until the first #endregion in a string, for example. By checking if these keywords were in a string, this commit now ensures the editor ignores strings and fold the section correctly. Fixes godotengine#89115.
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
When using the script editor, if the keywords #region and #endregion where in a string and at the start of the line, the editor would not ignore them and count them as the actual keywords, which when folded, would only fold until the first #endregion in a string, for example.
By checking if these keywords were in a string, this commit now ensures the editor ignores strings and fold the section correctly.
Fixes #89115.