Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] [C#] Use PropertyName constants in more places #89246

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

AThousandShips
Copy link
Member

Also fixed units for the rotation example, not entirely critical but could be confusing as it's not in degrees

Didn't touch the _indexed methods as they use both plain paths and sub-paths, unsure how to deal with those

Could add it to Tween as well but it doesn't have as clear a connection with any one class, added these to where there were already a note about using the PropertyName feature

@AThousandShips AThousandShips added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 7, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Mar 7, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner March 7, 2024 12:06
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akien-mga akien-mga merged commit aef11a1 into godotengine:master Mar 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the dotnet_name branch March 7, 2024 14:28
@AThousandShips
Copy link
Member Author

Thank you!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.
Cherry-picked for 4.1.4.

@akien-mga akien-mga removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 11, 2024
@akien-mga akien-mga changed the title [Docs][C#] Use PropertyName constants in more places [Docs] [C#] Use PropertyName constants in more places Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants