Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store values when loading them #89248

Merged
merged 1 commit into from
May 7, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Mar 7, 2024

I noticed some editor parts will read project metadata config and immediately write it to the same value, which is a faulty logic. This PR fixes all cases I could easily find.

@KoBeWi KoBeWi added this to the 4.3 milestone Mar 7, 2024
@KoBeWi KoBeWi changed the title Don't store link status when loading Don't store values when loading them Mar 7, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner March 7, 2024 14:01
@KoBeWi
Copy link
Member Author

KoBeWi commented Mar 7, 2024

I pushed some more changes, but I wonder if it can be handled better.

@Mickeon
Copy link
Contributor

Mickeon commented Mar 8, 2024

Indeed, that boolean initializing feels consistent across the board. There's a pattern.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for now, but we can indeed think about how to make this pattern more explicit and obvious to contributors.

@akien-mga akien-mga merged commit ba6f840 into godotengine:master May 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants