Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up inspector updates for TileMap #89251

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Mar 7, 2024

Fixes the issue mentioned in #89179 (comment) (it also applies to current TileMap, but somehow it's less visible)

The main culprits were TileSet hashing all its sources for generating preview and EditorInspectorArray trying to show tile_data.

@KoBeWi KoBeWi added this to the 4.3 milestone Mar 7, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner March 7, 2024 15:27
@KoBeWi KoBeWi force-pushed the fastpector branch 2 times, most recently from bae32c2 to b1eb41d Compare March 7, 2024 16:45
Copy link
Member

@groud groud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@akien-mga akien-mga merged commit 1c8ef9e into godotengine:master Mar 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the fastpector branch March 9, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants