Fix packed scene translation parser missing strings. #89286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix the POT generator missing strings.
(fixes Localization POT generation does not regognize text on instanced nodes. #74194, probably fixes POT generation with saved scenes loaded from another scene doesn't work #79144)
MenuButton
andOptionButton
case, as it's attempting to parse the old 3.x scene format.popup/item_0/text
property of the nodes with popup menus.(fixes Menu- and OptionButton item text strings don't get included in POT generation #88017)
I'm planning to add the lookup and exclude properties in the project settings, but i don't know how to do that yet.
This is my first time really working with c++ so i have no idea really what im doing.
It might be that the variable names im using are wrong.
I ported this code from a custom translation parser i made in gdscript.