Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible crash when converting a node to other in visual shader #89292

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Mar 8, 2024

I've detected that sometimes the editor crashing when the user use this option in visual shaders:

изображение

Visual shader node pointer become a null and crash:

изображение

After this fix, it will not.

@Chaosus Chaosus requested a review from a team as a code owner March 8, 2024 19:15
@Chaosus Chaosus added this to the 4.3 milestone Mar 8, 2024
@akien-mga akien-mga merged commit e9ca51c into godotengine:master Mar 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the vs_fix_crash branch March 9, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants