Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland: Stop unreachable warning #89306

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

alesliehughes
Copy link
Contributor

@alesliehughes alesliehughes commented Mar 9, 2024

*** CID 415586:  Control flow issues  (UNREACHABLE) /platform/linuxbsd/wayland/display_server_wayland.cpp: 590 in DisplayServerWayland::screen_is_kept_on() const() 584
585     bool DisplayServerWayland::screen_is_kept_on() const {
586     #ifdef DBUS_ENABLED
587     	return wayland_thread.window_get_idle_inhibition(MAIN_WINDOW_ID) || screensaver_inhibited;
588     #endif
589
>>>     CID 415586:  Control flow issues  (UNREACHABLE)
>>>     This code cannot be reached: "return this->wayland_thread...".
590     	return wayland_thread.window_get_idle_inhibition(MAIN_WINDOW_ID);
591     }
592
593     Vector<DisplayServer::WindowID> DisplayServerWayland::get_window_list() const {
594     	MutexLock mutex_lock(wayland_thread.mutex);
595

@alesliehughes alesliehughes requested a review from a team as a code owner March 9, 2024 03:20
Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that this should make no practical difference. That said, I suppose that this is more correct.

@AThousandShips
Copy link
Member

Please remove the code from your commit message, just a simple description is sufficient

@akien-mga akien-mga changed the title wayland: Stop unreachable warning Wayland: Stop unreachable warning Mar 9, 2024
@akien-mga akien-mga merged commit 43fd1f6 into godotengine:master Mar 9, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants