SCons: Ensure with statement where applicable
#89361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
force-pushed
the
scons/with-statement
branch
from
133664a
to
fb299d0
Compare
akien-mga
approved these changes
Mar 10, 2024
|
Pro tip for anyone else wanting to review this PR: in the diff page, if you click the gear icon you can tick the "hide whitespace" option. This, way, this 1.6K diff becomes like 100 lines long or something. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a handful of instances in the repo where a file is opened but never explicitly closed. Though this could've simply been a PR ensuring that there's a respective "close" function for all of these, the better option appeared to be applying the
withstatement's wrapping capabilities across the repo. This keyword was added in Python 3.6, and while most new code seems to utilize it, legacy code was never fully updated to support it after the minimum version was increased from 3.5. No significant code changes were made, beyond minor refactoring for fringe situations (eg: consolidating mutually exlusiveopencalls behind if/else into a single call)