Increase coverage of timestamps for visual profiler #89398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
force-pushed
the
visual-debugger-coverage
branch
from
d5fd32a to
087bab6
Compare
clayjohn
changed the title
BastiaanOlij
approved these changes
Mar 25, 2024
clayjohn
force-pushed
the
visual-debugger-coverage
branch
from
087bab6 to
ac6c648
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed these changes while profiling a big demo for W4 Games for GDC.
The way the timestamp system works is that everything between a given timestamp and the next one is included. So we have funny issues where things like "Resolve" seem to take a ton of the frame time because SDFGI and OmniLight shaders don't have timestamps.
It also adds timestamps for various (potentially expensive) updates that happen before we start rendering to viewports (reflection probes + particles).
Overall, this makes the visual profiler clearer and more accurate which is necessary to actually identify performance issues.