Only store vertices referenced by the indices per surface in the glTF importer #89418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuma
force-pushed
the
gltf_vertex_packing
branch
from
21097d3 to
3f7b4dc
Compare
lyuma
force-pushed
the
gltf_vertex_packing
branch
from
3f7b4dc to
ed7b3ab
Compare
fire
approved these changes
Mar 12, 2024
lyuma
force-pushed
the
gltf_vertex_packing
branch
from
ed7b3ab to
4ccd6a7
Compare
lyuma
force-pushed
the
gltf_vertex_packing
branch
from
4ccd6a7 to
77f6e35
Compare
AThousandShips
approved these changes
Mar 14, 2024
AThousandShips
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error present in many vrm gltf documents (such as exported VRM). In these cases, surfaces (aka gltf primitives) on a given mesh share their vertex buffer in the gltf document.
One example vrm file has 11 surfaces on a single mesh, all sharing the vertex buffer.
Before this change, the imported mesh data alone takes 318MB. After this change, the same mesh data is now down to 49MB
Fixes #80195