Add checks for scene type reimports #89428
Open
+32
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Mainly affects gltf and other custom importable files -Removes duplicate that is created -Adds safeties to certain parts of the EditorNode script
Jonathan-Jay-TB
changed the title
AThousandShips
changed the title
AThousandShips
added
bug
crash
topic:3d
topic:import
and removed
enhancement
topic:editor
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Removes duplicate scene that is added during reimport when it is safe to do so.
-Added some safeties to the set_edited_scene() function of the EditorNode script (doesn't check if the signal exists when disconnecting it, and same issue as the next point)
-Adds a safety to the _add_nodes() function of the SceneTreeEditor script (would print an error if the node had its parent changed from the viewport/null, which can happen in plugin scripts)
Could be improved by properly selecting the node directly to restore the node tree, instead of using set_edited_scene() on line 1063 of editor_node.cpp (possible slight efficiency gain)
Fixes #87451