Don't duplicate internal nodes #89442
Open
+15
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented in godotengine/godot-proposals#9282 (comment), this PR makes nodes added with
INTERNAL_MODE_FRONT
orINTERNAL_MODE_BACK
not duplicated, similar toparent_owned
. Also removedparent_owned
and related methods, because they are no longer needed. AFAIK all internal nodes already use the proper internal mode. I also added helper methodis_internal()
to make it easier to use.Supersedes #88114
Supersedes #89388
Supersedes #96018
Resolves godotengine/godot-proposals#9282 (with alternate solution)
Fixes #96246
Fixes #92880