Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Control::set_global_position for rotated/scaled transforms #89502

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix Control::set_global_position for rotated/scaled transforms #89502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions scene/gui/control.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1406,15 +1406,11 @@ void Control::_set_global_position(const Point2 &p_point) {

void Control::set_global_position(const Point2 &p_point, bool p_keep_offsets) {
ERR_MAIN_THREAD_GUARD;

Transform2D global_transform_cache = get_global_transform();
if (p_point == global_transform_cache.get_origin()) {
return; // Edge case, but avoids calculation.
}

Point2 internal_position = global_transform_cache.affine_inverse().xform(p_point);

set_position(internal_position + data.pos_cache, p_keep_offsets);
// (parent_global_transform * T(new_position) * internal_transform).origin == new_global_position
// (T(new_position) * internal_transform).origin == new_position_in_parent_space
// new_position == new_position_in_parent_space - internal_transform.origin
Point2 position_in_parent_space = data.parent_canvas_item ? data.parent_canvas_item->get_global_transform().affine_inverse().xform(p_point) : p_point;
set_position(position_in_parent_space - _get_internal_transform().get_origin(), p_keep_offsets);
Sauermann marked this conversation as resolved.
Show resolved Hide resolved
}

Point2 Control::get_global_position() const {
Expand Down
Loading