Allow for 32 max collisions in test_body_motion
#89517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
enhancement
topic:physics
cherrypick:4.2
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
max_collisionsparameter inPhysicsServer3D.body_test_motion, and by proxyPhysicsBody3D.test_moveandPhysicsBody3D.move_and_collide, is meant to be capped by the size of the fixed-sizecollisionsarray inPhysicsServer3D::MotionResultthat's set to the size ofPhysicsServer3D::MotionResult::MAX_COLLISIONS, which is currently 32.This is currently being bounds-checked with the
ERR_FAIL_INDEX_Vmacro when using Godot Physics, which incorrectly leads to an error when passing amax_collisionsof 32, as themax_collisionsparameter is treated as an index rather than a count.This PR addresses this by switching to
ERR_FAIL_COND_Vinstead.