Fix unexpected auto translation of editor Tree content
#89599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
changed the title
Tree contentTree content
|
I'm surprised you didn't include the changes in #89546 to supersede it. It would unite everything into a single commit. And about the compatibility, while you have a point, I think we should wait a little and see if it's affecting other people or if it's just an us problem. |
YeldhamDev
approved these changes
Mar 24, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some regressions due to
Treenow supports auto translation (#89032).This PR almost touched every
Treeused in the editor. The change of auto translation behavior affects compatibility. I think we could alternatively makeTreenot auto translating by default.CC @YeldhamDev
Supersedes #89546