Resource file not found error when loading Favorite icon #89642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
approved these changes
Mar 18, 2024
|
Maybe don't merge this until #89646 is resolved. |
|
How is this related to that issue? Does removing the error make it even slower? |
There is no slowdown at all until you apply this fix. The error means that no scene files are loaded for the favorites, and loading the scenes is what is causing the slowdown as far as I can tell. |
permelin
force-pushed
the
fix-favorite-icon
branch
from
264a767 to
ae6410b
Compare
|
Pushed an update. This PR now fixes:
|
KoBeWi
approved these changes
Mar 19, 2024
akien-mga
closed this pull request by merging all changes
into
godotengine:master
in
06abc86
akien-mga
added a commit
that referenced
this pull request
Mar 24, 2024
Resource file not found error when loading Favorite icon
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of two arguments were flipped in recently merged #77932. If you had any favorites in the file dock, you would get
ERROR: Resource file not found: res://PackedScene (expected type: )cc: @KoBeWi.