[GDScript] Correctly report invalid read-only access #89648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
force-pushed
the
read_only_check_2
branch
from
4e508d9 to
fda8dae
Compare
AThousandShips
commented
Mar 18, 2024
There was a problem hiding this comment.
These are largely whitespace changes as I put the read-only check first for convenience
AThousandShips
force-pushed
the
read_only_check_2
branch
from
fda8dae to
502dab5
Compare
vnen
approved these changes
Apr 29, 2024
|
Any suggestions for a clearer one welcome, don't know what else to say with it |
AThousandShips
force-pushed
the
read_only_check_2
branch
from
502dab5 to
c4e24d2
Compare
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that read-only assignments are reported correctly, initially tried a fix using the setter system but it added a lot of extra complexity that wasn't helpful, so went with an explicit check on the script side using a new function on
Variant, and added to a number of places in the VM, unsure if all these are needed but added them anywhere there was a set operation