Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Improve DocGen for non-constant expressions #89738

Merged
merged 1 commit into from
Apr 23, 2024
Merged

GDScript: Improve DocGen for non-constant expressions #89738

merged 1 commit into from
Apr 23, 2024

Conversation

dalexeev
Copy link
Member 

func test(a = [], b = a, c = {x = 0}):
    pass

Before

After

@dalexeev dalexeev added this to the 4.3 milestone Mar 21, 2024
@dalexeev dalexeev requested a review from a team as a code owner March 21, 2024 09:34
adamscott
adamscott approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed during the GDScript meeting. Looks fine to us! Thanks @dalexeev !

@akien-mga akien-mga merged commit 13b66bc into godotengine:master Apr 23, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-docgen-improve-non-constant branch April 23, 2024 18:22
This was referenced Jun 4, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
enhancement topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@dalexeev @akien-mga @adamscott