Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress bar when updating scene groups #89739

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Add progress bar when updating scene groups #89739

merged 1 commit into from
Apr 15, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes first part of #89516

@AThousandShips AThousandShips added this to the 4.3 milestone Mar 21, 2024
@jsjtxietian jsjtxietian mentioned this pull request Mar 21, 2024
Open
2 tasks
@AThousandShips AThousandShips changed the title Add progress bar when update scene groups Add progress bar when updating scene groups Mar 21, 2024
ajreckof
ajreckof approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@ajreckof ajreckof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this works as expected. Code looks good to me

@akien-mga akien-mga requested a review from KoBeWi April 14, 2024 12:46
KoBeWi
KoBeWi approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks ok.

@akien-mga akien-mga merged commit ce2a09f into godotengine:master Apr 15, 2024
16 checks passed
@jsjtxietian jsjtxietian deleted the group-step branch April 15, 2024 16:17
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi mentioned this pull request Apr 17, 2024
Merged
@KoBeWi KoBeWi mentioned this pull request Jul 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@ajreckof ajreckof ajreckof approved these changes

Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@jsjtxietian @akien-mga @KoBeWi @ajreckof @AThousandShips