Remove redundant code in Node3D
#89753
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Mar 21, 2024
| } else { | ||
| data.local_transform = get_transform(); | ||
| } | ||
| data.local_transform = get_transform(); | ||
| _replace_dirty_mask(DIRTY_EULER_ROTATION_AND_SCALE); // As local transform was updated, rot/scale should be dirty. |
There was a problem hiding this comment.
I'm honestly unsure if this is valid, there's no change to that part of the transform here, so maybe the whole block should be removed, but haven't tested the details and unsure what to look for
AThousandShips
force-pushed
the
redundant_3d
branch
from
a050d87
to
d6bbbfd
Compare
AThousandShips
force-pushed
the
redundant_3d
branch
from
d6bbbfd
to
f526ac4
Compare
AThousandShips
force-pushed
the
redundant_3d
branch
from
f526ac4
to
d837d64
Compare
AThousandShips
force-pushed
the
redundant_3d
branch
from
d837d64
to
ceed302
Compare
AThousandShips
force-pushed
the
redundant_3d
branch
from
ceed302
to
bedb312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know this code well enough to know if the entire block isn't redundant, I'm not sure what the need for assigning
local_transformis here if we're just taking the existing transform, as we'll update the dirty transform later anyway, but keeping the change small for the momentFollowup to:
Node3Dchildren usingtop_levelin different position in-editor versus runtime #84643