Fix import and saving related crashes #89780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResourceSaver
This adds the check from
core_bind
toResourceSaver
directly,could remove the one in, it helps catch broken cases when doing things from c++ResourceSaver.save
incore_bind
as it's now redundant, but just added it for nowThe obj side avoids doing any of the remaining code, makes things a bit clearer, and matches the code here:
godot/editor/import/3d/resource_importer_obj.cpp
Lines 441 to 445 in fe01776
For this specific case we might want to look at adding support for lines in obj files as they support it, or a more clear error message or warning when using unsupported features, but that's outside the scope of this