Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing RenderInfoType enum to Viewport #89805

Merged
1 commit merged into from
Mar 25, 2024
Merged

Add missing RenderInfoType enum to Viewport #89805

1 commit merged into from
Mar 25, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Mar 23, 2024 •
edited
Loading

As added in:

Also added details to the documentation of these copied from RenderingServer

@AThousandShips AThousandShips added this to the 4.3 milestone Mar 23, 2024
@AThousandShips AThousandShips requested review from a team as code owners March 23, 2024 13:10
@AThousandShips AThousandShips requested a review from a team March 23, 2024 13:26
BastiaanOlij
BastiaanOlij approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

akien-mga added a commit that referenced this pull request Mar 25, 2024
@akien-mga
Merge pull request #89805 from AThousandShips/viewport_report
17c66c0 
Add missing `RenderInfoType` enum to `Viewport`
@akien-mga akien-mga closed this pull request by merging all changes into godotengine:master in 0acfb38 Mar 25, 2024
@AThousandShips AThousandShips deleted the viewport_report branch March 25, 2024 10:22
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @akien-mga @BastiaanOlij