Remove a redundant MAX comparison within a loop in compute_image_metrics.
#89889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
AThousandShips
approved these changes
Mar 25, 2024
akien-mga
changed the title
MAX comparison within a loop in compute_image_metrics`.
akien-mga
changed the title
MAX comparison within a loop in compute_image_metrics`.MAX comparison within a loop in compute_image_metrics.
|
The change looks fine, but could you amend the commit title to be shorter? Something like this PR title would be fine. The current one wraps over 4 lines and refers to line numbers which will not mean much to a changelog reader. See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind for details on how commit messages should be written. |
akien-mga
force-pushed
the
compute_image_metrics-fix
branch
from
4a75ec5
to
75d6519
Compare
|
Amended the commit message myself. |
|
Thanks!
…On Thu, Mar 28, 2024 at 5:23 PM Rémi Verschelde ***@***.***> wrote:
Amended the commit message myself.
—
Reply to this email directly, view it on GitHub
<#89889 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACE3DQVPKVRKTIBPXW4QQY3Y2R35ZAVCNFSM6AAAAABFHRPQD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWGE2TKMBTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In compute_image_metrics the variable image_metric_max is set to 0 on ln4110 and the for loop on ln4112 is i=0->256. Variable image_metric_max is not set elsewhere and i is only changed in the loop increment therefore the MAX comparison on ln4117 is redundant as i will always be >= image_metric_max.