Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Path3D picking working incorrectly when viewport is in half resolution #89901

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #89885

Have to use some Node3DEditorViewport 's functionality so that requires expose three camera related private functions.

@jsjtxietian jsjtxietian requested a review from a team as a code owner March 26, 2024 09:26
@AThousandShips AThousandShips added bug topic:editor topic:3d cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 26, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Mar 26, 2024
@akien-mga akien-mga changed the title Fix Path3d's pick works incorrectly when viewport is in half resolution Fix Path3D picking working incorrectly when viewport is in half resolution Mar 26, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but looks like a sensible approach.

@akien-mga akien-mga merged commit 3fa6ec7 into godotengine:master Mar 26, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the path3d branch March 27, 2024 02:38
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path3D: adds points at wrong positions when Viewport is in half resolution
3 participants