Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Control z-index warning #89956

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Mar 27, 2024

Addresses #69895

The warning message now mentions that it can be disabled: is completely gone.

@KoBeWi KoBeWi added this to the 4.x milestone Mar 27, 2024
@KoBeWi KoBeWi requested review from a team as code owners March 27, 2024 20:50
@Geometror
Copy link
Member

I'm in favor of providing a way to disable this warning. After reading through #69895 it looks like that a dedicated project setting is justified in this case as many users have strong feelings about the presence of that warning :) Well aware that this isn't the best (permanent) solution, but I think it's the best we can currently do without major/breaking changes to the configuration warning system.

@YeldhamDev
Copy link
Member

This feels like a band-aid. It would be better to have a way to silence any warning.

@KoBeWi
Copy link
Member Author

KoBeWi commented Mar 28, 2024

Do you have a specific system in mind for disabling warning though? It was mentioned many times, but no one even opened a proposal so far.

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general control of warning display would be nice, but IMO this is a special case, many other warnings are less relevant to hide (like collision objects without shapes, which isn't really valid, scale warnings, etc.), this one is simply information, rather than something being wrong as such

We might even want to add categories to warnings in the future to distinguish "warnings" from "information", with a white triangle perhaps

@AThousandShips AThousandShips changed the title Allow to disable Control z-index warning Allow disabling Control z-index warning Mar 28, 2024
@akien-mga
Copy link
Member

This feels pretty hacky to me. And since it needs to be configured in the project settings, users who know and don't care to keep being reminded about this will need to disable it manually in every single project they make that users Z index on Controls.

IMO, aside from a more involved system to make configuration warnings more flexible as suggested in godotengine/godot-proposals#9416, this particular one may just need to go. A crystal clear warning in the documentation should be sufficient. We can try, and if we find that too many users are confused, we can add a warning back. But currently we only tried with a warning and thus with users confused by the warning, and not by what it teaches them.

@KoBeWi
Copy link
Member Author

KoBeWi commented Apr 4, 2024

A crystal clear warning in the documentation should be sufficient.

Where though? In z_index description, which is in CanvasItem?

@akien-mga
Copy link
Member

A crystal clear warning in the documentation should be sufficient.

Where though? In z_index description, which is in CanvasItem?

Yeah I think so. And maybe a note in the Control description?

@KoBeWi KoBeWi force-pushed the warning!_self_destruct_sequence_activated branch 2 times, most recently from afa1f2a to dd0deac Compare April 4, 2024 15:20
@KoBeWi KoBeWi changed the title Allow disabling Control z-index warning Remove Control z-index warning Apr 4, 2024
@KoBeWi
Copy link
Member Author

KoBeWi commented Apr 4, 2024

I removed the warning. Seems like it's sufficiently documented already.

@KoBeWi KoBeWi force-pushed the warning!_self_destruct_sequence_activated branch from dd0deac to c3d2fab Compare April 4, 2024 15:22
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 4, 2024
@akien-mga akien-mga merged commit 5411608 into godotengine:master Apr 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the warning!_self_destruct_sequence_activated branch April 5, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants