Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll to description #90035

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Mar 30, 2024

Fixes #88281

I verified that scroll_to_paragrah() is called with the same argument, but apparently it's too early, because it scrolls to completely wrong position. I tried setting scroll_to regardless of is_ready(), but it doesn't help.

I call the thing I used "super_call_deferred()" in my project and it sometimes helps me to fix bugs, but I didn't expect that it would help in the engine too :/ If anyone knows a better solution feel free to suggest it, but the issue has to be fixed quick, because it's annoying.

EDIT:
I did something less hacky.

@KoBeWi KoBeWi force-pushed the SUPER_CALL_DEFERRED branch from b43f527 to 5a8066b Compare March 31, 2024 12:30
Copy link
Member

@ajreckof ajreckof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works perfectly. Code is simple and clear.

@akien-mga akien-mga merged commit 9b0b7af into godotengine:master Apr 14, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the SUPER_CALL_DEFERRED branch April 14, 2024 12:51
@aXu-AP
Copy link
Contributor

aXu-AP commented Apr 14, 2024

Thanks for fixing a regression from my pr... I've been quite busy lately so it could've taken some time for me to do it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release regression topic:editor usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jumping to description from help search will scroll to bottom if class page is short
5 participants