Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MeshInstance3D.get_skin_reference and add docs #90056

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

lyuma
Copy link
Contributor

@lyuma lyuma commented Mar 30, 2024

SkinReference was missing documentation.

Also, there was not an obvious way to access the skin_ref used internally by a particular MeshInstnace3D node, so this adds a getter so the actual SkinReference object used by the MeshInstance3D can be accessed without going through Skeleton.

There was a discussion on the #animation channel on RocketChat. CC @smix8

@lyuma lyuma requested review from a team as code owners March 30, 2024 22:11
@lyuma lyuma force-pushed the get_skin_reference branch 2 times, most recently from ed2e858 to 0286eee Compare March 30, 2024 23:30
Copy link
Contributor

@smix8 smix8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for the exposed function.

Without this the RenderingServer skeleton API can not be used in scripting with the default skin because there is no access to it.

doc/classes/SkinReference.xml Outdated Show resolved Hide resolved
doc/classes/SkinReference.xml Outdated Show resolved Hide resolved
doc/classes/SkinReference.xml Outdated Show resolved Hide resolved
doc/classes/MeshInstance3D.xml Outdated Show resolved Hide resolved
@AThousandShips AThousandShips added this to the 4.3 milestone Mar 31, 2024
@akien-mga akien-mga changed the title Expose MeshInstance3D.get_skin_reference and add docs Expose MeshInstance3D.get_skin_reference and add docs Apr 4, 2024
@akien-mga
Copy link
Member

akien-mga commented Apr 8, 2024

@lyuma Ping for documentation style fixes before merging.

Edit: Amended myself.

@akien-mga akien-mga merged commit 4b82e90 into godotengine:master Apr 10, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants