Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small error in Variant doc #90088

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Jordyfel
Copy link
Contributor

@Jordyfel Jordyfel commented Apr 1, 2024

This comment is referring to the statically typed variable declared in the above line.

Static variables exist in GDScript and they are a different thing so this should be fixed.

@Jordyfel Jordyfel requested a review from a team as a code owner April 1, 2024 00:11
@timothyqiu timothyqiu added this to the 4.3 milestone Apr 1, 2024
@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 1, 2024
@dalexeev
Copy link
Member

dalexeev commented Apr 2, 2024

Could you please correct this bug by the way? Should be TYPE_INT.

TYPE_INTEGER:

@Jordyfel Jordyfel force-pushed the statically-typed-not-static branch from a7f5cbe to e41209c Compare April 2, 2024 21:32
@akien-mga akien-mga merged commit 72e9e57 into godotengine:master Apr 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Jordyfel Jordyfel deleted the statically-typed-not-static branch April 4, 2024 15:01
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 8, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.1.4.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants