Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unavailable property binding reset_on_save from Skeleton3D #90231

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Remove unavailable property binding reset_on_save from Skeleton3D #90231

merged 1 commit into from
Apr 5, 2024

Conversation

TokageItLab
Copy link
Member

Sorry, Fixes #90224.

@TokageItLab TokageItLab added this to the 4.3 milestone Apr 4, 2024
@TokageItLab TokageItLab requested a review from a team April 4, 2024 23:46
@TokageItLab TokageItLab requested a review from a team as a code owner April 4, 2024 23:46
@TokageItLab TokageItLab changed the title Remove unavailed property binding reset_on_save from Skeleton3D Remove unavailable property binding reset_on_save from Skeleton3D Apr 4, 2024
fire
fire approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@akien-mga akien-mga changed the title Remove unavailable property binding reset_on_save from Skeleton3D Remove unavailable property binding reset_on_save from Skeleton3D Apr 5, 2024
@catboy-catfish
Copy link

catboy-catfish commented Apr 5, 2024 •
edited
Loading

Do you know if reset_on_save is used anywhere in Skeleton3D?

@TokageItLab
Copy link
Member Author

TokageItLab commented Apr 5, 2024 •
edited
Loading

As noted in the issue in the description, I just forgot to remove it during the final adjustment of the SkeletonModifier implementation PR, and it was never availed in practice on master.

@akien-mga akien-mga merged commit 4d20840 into godotengine:master Apr 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@catboy-catfish
Copy link

Given how it was just now merged into master this looks pretty good

@TokageItLab TokageItLab deleted the mod-reset branch April 5, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug regression topic:animation topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Skeleton3D modifier_reset_on_save has invalid setter/getter bindings
4 participants
@TokageItLab @catboy-catfish @akien-mga @fire