Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ClassDB::is_enum_bitfield as ClassDB::is_class_enum_bitfield #90368

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Naros
Copy link
Contributor

@Naros Naros commented Apr 8, 2024

Currently, there isn't a way for plug-in authors to resolve whether a given class-defined enum is a bitfield. Having this knowledge exposed allows plug-in authors to render UIs and handle this specific case differently from normal enum types.

@Naros Naros requested review from a team as code owners April 8, 2024 00:13
@Naros Naros force-pushed the expose-classdb-is-enum-bitfield branch from 4eda5fc to ef1ebfc Compare April 8, 2024 01:01
@AThousandShips AThousandShips added this to the 4.x milestone Apr 8, 2024
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not review the code, but enhancements helping gdextension authors have a better quality of life is a worthy goal.

Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! The code looks good. Thanks!

doc/classes/ClassDB.xml Outdated Show resolved Hide resolved
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 18, 2024
@Naros Naros force-pushed the expose-classdb-is-enum-bitfield branch from ef1ebfc to a559288 Compare April 19, 2024 16:23
@Naros Naros force-pushed the expose-classdb-is-enum-bitfield branch from a559288 to c936ee5 Compare April 19, 2024 16:46
@akien-mga akien-mga merged commit 0b89b8b into godotengine:master Apr 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants